Thnaks for point Best Regards, Oleksandr Shamray
> -----Original Message----- > From: Philippe Ombredanne [mailto:pombreda...@nexb.com] > Sent: Thursday, November 30, 2017 10:21 AM > To: Kun Yi <ku...@google.com> > Cc: Oleksandr Shamray <oleksan...@mellanox.com>; Greg Kroah-Hartman > <gre...@linuxfoundation.org>; a...@arndb.de; system-sw-low-level <system- > sw-low-le...@mellanox.com>; devicet...@vger.kernel.org; j...@resnulli.us; > Vadim Pasternak <vad...@mellanox.com>; linux-...@vger.kernel.org; > OpenBMC Maillist <open...@lists.ozlabs.org>; LKML <linux- > ker...@vger.kernel.org>; openocd-devel-ow...@lists.sourceforge.net; > m...@shout.net; Jiri Pirko <j...@mellanox.com>; robh...@kernel.org; linux- > ser...@vger.kernel.org; tklau...@distanz.ch; Mauro Carvalho Chehab > <mche...@kernel.org>; David S. Miller <da...@davemloft.net>; linux-arm- > ker...@lists.infradead.org > Subject: Re: [patch v12 2/4] drivers: jtag: Add Aspeed SoC 24xx and 25xx > families JTAG master driver > > On Wed, Nov 29, 2017 at 11:51 PM, Kun Yi <ku...@google.com> wrote: > > On Tue, Nov 14, 2017 at 8:11 AM, Oleksandr Shamray > > <oleksan...@mellanox.com> wrote: > [] > >> diff --git a/drivers/jtag/jtag-aspeed.c b/drivers/jtag/jtag-aspeed.c > >> new file mode 100644 index 0000000..a6e2417 > >> --- /dev/null > >> +++ b/drivers/jtag/jtag-aspeed.c > >> @@ -0,0 +1,782 @@ > >> +/* > >> + * drivers/jtag/aspeed-jtag.c > >> + * > >> + * Copyright (c) 2017 Mellanox Technologies. All rights reserved. > >> + * Copyright (c) 2017 Oleksandr Shamray <oleksan...@mellanox.com> > >> + * > >> + * Released under the GPLv2 only. > >> + * SPDX-License-Identifier: GPL-2.0 > >> + */ > > I think the SPDX id should be on the first line as requested by Linus and > documented by Thomas (tglx) and Greg (greg-kh). And it should use // > comments, e.g: > > // SPDX-License-Identifier: GPL-2.0 > > See the threads discussing all these. > > > -- > Cordially > Philippe Ombredanne
