> On Nov 27, 2017, at 4:00 PM, Gustavo A. R. Silva <garsi...@embeddedor.com> > wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com>
Looks good to me. We had the same patch in upstream PR#690 [1]. I believe that PR#695 [2] was also necessary to quiet the warning. [1] https://github.com/facebook/zstd/pull/690/files [2] https://github.com/facebook/zstd/pull/695/files Reviewed-by: Nick Terrell <terre...@fb.com>