Re: [PATCH] slub: Fix sysfs duplicate filename creation when slub_debug=O

[kbuild test robot]

Hi Miles,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mmotm/master]
[also build test ERROR on v4.14-rc8 next-20171107]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/miles-chen-mediatek-com/slub-Fix-sysfs-duplicate-filename-creation-when-slub_debug-O/20171108-100701
base:   git://git.cmpxchg.org/linux-mmotm.git master
config: i386-randconfig-x001-201745 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   mm/slub.c: In function 'sysfs_slab_add':
>> mm/slub.c:5713:18: error: 'SLAB_NEVER_MERGE' undeclared (first use in this 
>> function)
       (slub_debug & SLAB_NEVER_MERGE))
                     ^~~~~~~~~~~~~~~~
   mm/slub.c:5713:18: note: each undeclared identifier is reported only once 
for each function it appears in

vim +/SLAB_NEVER_MERGE +5713 mm/slub.c

  5697  
  5698  static int sysfs_slab_add(struct kmem_cache *s)
  5699  {
  5700          int err;
  5701          const char *name;
  5702          struct kset *kset = cache_kset(s);
  5703          int unmergeable = slab_unmergeable(s);
  5704  
  5705          INIT_WORK(&s->kobj_remove_work, sysfs_slab_remove_workfn);
  5706  
  5707          if (!kset) {
  5708                  kobject_init(&s->kobj, &slab_ktype);
  5709                  return 0;
  5710          }
  5711  
  5712          if (!unmergeable && disable_higher_order_debug &&
> 5713                          (slub_debug & SLAB_NEVER_MERGE))
  5714                  unmergeable = 1;
  5715  
  5716          if (unmergeable) {
  5717                  /*
  5718                   * Slabcache can never be merged so we can use the name 
proper.
  5719                   * This is typically the case for debug situations. In 
that
  5720                   * case we can catch duplicate names easily.
  5721                   */
  5722                  sysfs_remove_link(&slab_kset->kobj, s->name);
  5723                  name = s->name;
  5724          } else {
  5725                  /*
  5726                   * Create a unique name for the slab as a target
  5727                   * for the symlinks.
  5728                   */
  5729                  name = create_unique_id(s);
  5730          }
  5731  
  5732          s->kobj.kset = kset;
  5733          err = kobject_init_and_add(&s->kobj, &slab_ktype, NULL, "%s", 
name);
  5734          if (err)
  5735                  goto out;
  5736  
  5737          err = sysfs_create_group(&s->kobj, &slab_attr_group);
  5738          if (err)
  5739                  goto out_del_kobj;
  5740  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

.config.gz
Description: application/gzip