On Sat, Nov 04, 2017 at 11:52:54PM -0500, Gustavo A. R. Silva wrote:
> Add a ̣̣continue statement in order to avoid using a previously
> free'd pointer tunnel in list_add.
>
> Addresses-Coverity-ID: 1415336
> Fixes: 9d3cce0b6136 ("thunderbolt: Introduce thunderbolt bus and connection
> manager")
> Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com>
Good catch!
Acked-by: Mika Westerberg <mika.westerb...@linux.intel.com>
Greg, can you pick this to your char-misc tree? Thanks.
> ---
> drivers/thunderbolt/tb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/thunderbolt/tb.c b/drivers/thunderbolt/tb.c
> index d674e06..1424581 100644
> --- a/drivers/thunderbolt/tb.c
> +++ b/drivers/thunderbolt/tb.c
> @@ -225,6 +225,7 @@ static void tb_activate_pcie_devices(struct tb *tb)
> tb_port_info(up_port,
> "PCIe tunnel activation failed,
> aborting\n");
> tb_pci_free(tunnel);
> + continue;
> }
>
> list_add(&tunnel->list, &tcm->tunnel_list);
> --
> 2.7.4
