On Sun, Nov 5, 2017 at 7:38 AM, Johan Hovold <jo...@kernel.org> wrote:
> On Tue, Oct 31, 2017 at 09:36:53AM -0700, Andrey Smirnov wrote:
>> Add code implementing managed version of serdev_device_open() for
>> serdev device drivers that "open" the device during driver's lifecycle
>> only once (e.g. opened in .probe() and closed in .remove()).
>>
>> Cc: linux-kernel@vger.kernel.org
>> Cc: linux-ser...@vger.kernel.org
>> Cc: Rob Herring <r...@kernel.org>
>> Cc: cphe...@gmail.com
>> Cc: Guenter Roeck <li...@roeck-us.net>
>> Cc: Lucas Stach <l.st...@pengutronix.de>
>> Cc: Nikita Yushchenko <nikita.yo...@cogentembedded.com>
>> Cc: Lee Jones <lee.jo...@linaro.org>
>> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
>> Cc: Pavel Machek <pa...@ucw.cz>
>> Cc: Andy Shevchenko <andy.shevche...@gmail.com>
>> Cc: Johan Hovold <jo...@kernel.org>
>> Cc: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
>> Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
>> Reviewed-by: Guenter Roeck <li...@roeck-us.net>
>> Signed-off-by: Andrey Smirnov <andrew.smir...@gmail.com>
>> ---
>> Documentation/driver-model/devres.txt | 3 +++
>> drivers/tty/serdev/core.c | 27 +++++++++++++++++++++++++++
>> include/linux/serdev.h | 1 +
>> 3 files changed, 31 insertions(+)
>
>> +int devm_serdev_device_open(struct device *dev, struct serdev_device
>> *serdev)
>> +{
>> + struct serdev_device **dr;
>> + int ret;
>> +
>> + dr = devres_alloc(devm_serdev_device_release, sizeof(*dr), GFP_KERNEL);
>> + if (!dr)
>> + return -ENOMEM;
>> +
>> + ret = serdev_device_open(serdev);
>> + if (ret) {
>> + devres_free(dr);
>> + return ret;
>> + }
>> +
>> + *dr = serdev;
>> + devres_add(dev, dr);
>> +
>> + return ret;
>
> This would be more readable as return 0.
Sure, I'll change that in v11.
Thanks,
Andrey Smrinov
