On Tue, Oct 31, 2017 at 06:10:00PM +0000, Long Li wrote: > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, October 31, 2017 1:43 AM > > To: Long Li <lon...@microsoft.com> > > Cc: KY Srinivasan <k...@microsoft.com>; Haiyang Zhang > > <haiya...@microsoft.com>; Stephen Hemminger <sthem...@microsoft.com>; > > de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; Paul Meyer > > <paul.me...@microsoft.com> > > Subject: Re: [PATCH] hv: kvp: Avoid reading past allocated blocks from KVP > > file > > > > On Mon, Oct 30, 2017 at 05:08:03PM -0700, Long Li wrote: > > > From: Paul Meyer <paul.me...@microsoft.com> > > > > > > While reading in more than one block (50) of KVP records, the > > > allocation goes per block, but the reads used the total number of > > > allocated records (without resetting the pointer/stream). This causes > > > the records buffer to overrun when the refresh reads more than one > > > block over the previous capacity (e.g. reading more than 100 KVP records > > whereas the in-memory database was empty before). > > > > Please wrap changelogs at 72 columns like your editor asked you to... > > I will fix it. > > > > > > > > > Fix this by reading the correct number of KVP records from file each time. > > > > > > Signed-off-by: Paul Meyer <paul.me...@microsoft.com> > > > --- > > > > Why is your name not also on the signed-off-by chain if you are forwarding > > on a > > patch from someone else? > > > > Is this patch also needed on stable kernels? > > I'm sending on behalf of Paul Meyer. I will add a "Reviewed-by:" tag.
Sending on behalf means you should add your signed-off-by, as it is going through you. thanks, greg k-h
