On Thu, May 03, 2007 at 02:32:33PM -0400, Jeff Layton wrote: > We had a customer report that attempting to make CIFS mount with a null > username (i.e. doing an anonymous mount) doesn't work. Looking through the > code, it looks like CIFS expects a NULL username from userspace in order > to trigger an anonymous mount. The mount.cifs code doesn't seem to ever > pass a null username to the kernel, however. > > It looks also like the kernel can take a sec=none option, but it only seems > to look at it if the username is already NULL. This seems redundant and > effectively makes sec=none useless. > > The following patch makes sec=none force an anonymous mount. I've briefly > tested it and it seems to work. I suppose we could alternately do some > stuff in userspace to make mount.cifs force a null username instead, but this > seems more straightforward to me.
Looks useful. In case you have some spare time at your hand it would be really nice to convert cifs option parsing to the lib/parser.c code and move all validation of the arguments into one place, so it's easily understanable and better to maintain. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/