Commit-ID:  24208435e343679b21502fb90786084dfaf15369
Gitweb:     https://git.kernel.org/tip/24208435e343679b21502fb90786084dfaf15369
Author:     Byungchul Park <byungchul.p...@lge.com>
AuthorDate: Wed, 25 Oct 2017 17:55:59 +0900
Committer:  Ingo Molnar <mi...@kernel.org>
CommitDate: Wed, 25 Oct 2017 12:19:00 +0200

locking/lockdep, sched/completions: Change the prefix of lock name for 
completion variables

CONFIG_LOCKDEP_COMPLETIONS uses "(complete)" as a prefix of lock name
for completion variable.

However, what we should use here is a noun - so use "(completion)" instead.

Suggested-by: Ingo Molnar <mi...@kernel.org>
Signed-off-by: Byungchul Park <byungchul.p...@lge.com>
Cc: Linus Torvalds <torva...@linux-foundation.org>
Cc: Peter Zijlstra <pet...@infradead.org>
Cc: Thomas Gleixner <t...@linutronix.de>
Cc: amir7...@gmail.com
Cc: ax...@kernel.dk
Cc: darrick.w...@oracle.com
Cc: da...@fromorbit.com
Cc: h...@infradead.org
Cc: idryo...@gmail.com
Cc: jo...@kernel.org
Cc: johannes.b...@intel.com
Cc: kernel-t...@lge.com
Cc: linux-bl...@vger.kernel.org
Cc: linux-fsde...@vger.kernel.org
Cc: linux...@kvack.org
Cc: linux-...@vger.kernel.org
Cc: o...@redhat.com
Cc: t...@kernel.org
Link: 
http://lkml.kernel.org/r/1508921765-15396-4-git-send-email-byungchul.p...@lge.com
Signed-off-by: Ingo Molnar <mi...@kernel.org>
---
 include/linux/completion.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/completion.h b/include/linux/completion.h
index cae5400..9121803 100644
--- a/include/linux/completion.h
+++ b/include/linux/completion.h
@@ -53,7 +53,7 @@ static inline void complete_release_commit(struct completion 
*x)
 do {                                                                   \
        static struct lock_class_key __key;                             \
        lockdep_init_map_crosslock((struct lockdep_map *)&(x)->map,     \
-                       "(complete)" #x,                                \
+                       "(completion)" #x,                              \
                        &__key, 0);                                     \
        __init_completion(x);                                           \
 } while (0)
@@ -67,7 +67,7 @@ static inline void complete_release_commit(struct completion 
*x) {}
 #ifdef CONFIG_LOCKDEP_COMPLETIONS
 #define COMPLETION_INITIALIZER(work) \
        { 0, __WAIT_QUEUE_HEAD_INITIALIZER((work).wait), \
-       STATIC_CROSS_LOCKDEP_MAP_INIT("(complete)" #work, &(work)) }
+       STATIC_CROSS_LOCKDEP_MAP_INIT("(completion)" #work, &(work)) }
 #else
 #define COMPLETION_INITIALIZER(work) \
        { 0, __WAIT_QUEUE_HEAD_INITIALIZER((work).wait) }

Reply via email to