On Mon, Oct 23, 2017 at 11:59:39PM -0700, Bin Meng wrote: > The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform > data. Select it in the Kconfig. > > Signed-off-by: Bin Meng <bmeng...@gmail.com> > > --- > > Changes in v2: > - Enforce dependency on PCI > > drivers/mtd/spi-nor/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig > index f26aaa6..abf453a 100644 > --- a/drivers/mtd/spi-nor/Kconfig > +++ b/drivers/mtd/spi-nor/Kconfig > @@ -107,8 +107,9 @@ config SPI_INTEL_SPI_PCI > > config SPI_INTEL_SPI_PLATFORM > tristate "Intel PCH/PCU SPI flash platform driver" if EXPERT > - depends on X86 > + depends on X86 && PCI
It is kind of weird to depend on PCI if we want to enable *platform* driver but whatever. I would still prefer to have dependency for LPC_ICH instead. No strong feelings though - as long as it builds and works fine :-) > select SPI_INTEL_SPI > + select LPC_ICH > help > This enables platform support for the Intel PCH/PCU SPI > controller in master mode. This controller is present in modern > -- > 2.7.4
