Hi! > > >> drivers/platform/Kconfig | 2 + > > >> drivers/platform/Makefile | 1 + > > >> drivers/platform/rave/Kconfig | 26 ++ > > >> drivers/platform/rave/Makefile | 1 + > > >> drivers/platform/rave/rave-sp.c | 677 > > >> ++++++++++++++++++++++++++++++++++++++++ > > > > > > First of all, why do these live in drivers/platform and why don't use > > > the mfd subsystem to implement this driver (instead of rolling your own > > > mfd-implementation)? > > > > > > > Because when I submitted this driver to MFD Lee Jones told me that it > > didn't belong to that subsystem and should be added to the kernel in > > "drivers/platform". > > When I first reviewed this driver, it looked far too complex to be an > MFD driver. Most of the code doesn't deal with what I'd expect to be > handled in MFD. Why do you have ~600 lines of protocol handling?
Some drivers are more complex than other ones... I don't think that's
unexpected.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
