> > +/* Clear learned (non-static) entry on given port */ > > +static void alr_loop_cb_del_port_learned(struct lan9303 *chip, u32 dat0, > > + u32 dat1, int portmap, void *ctx) > > +{ > > + int *port = ctx; > > You can get the value directly to make the line below more readable: > > int port = *(int *)ctx;
You have to be a bit careful with this. You often see people submitting patches taking away casts for void * pointers. If they do that here, it should at least not compile... So maybe do it in two steps? int * pport = ctx; int port = *pport; ??? Andrew