On Wed, Oct 18, 2017 at 3:12 AM, Arnd Bergmann <a...@arndb.de> wrote: > On Wed, Oct 18, 2017 at 4:04 AM, Kees Cook <keesc...@chromium.org> wrote: >> (re-sending to Jessica's @korg address...) >> >> The module_param_call() macro was explicitly casting the .set and .get >> function prototypes away with (void *). This can lead to hard-to-find >> type mismatches. Additionally, it creates problems for static checkers >> and Control Flow Itegrity compiler features, which depend on clustering >> function call sites based on prototype signature. >> >> This removes the casts and fixes all the incorrect prototypes tree-wide. > > I've applied the patch to my randconfig test setup, will let you know if I > find > any regressions today. > > I did notice that patch 2 has a conflict against the ipmi driver, I had to > manuall port that one part. Splitting up patch 2 would help there, but > complicates other things.
Yeah, it was a small enough treewide change on code that normally doesn't change much, so I figured it could stand as a regular patch. -Kees -- Kees Cook Pixel Security
