> +static void ksz9477_phy_setup(struct ksz_device *dev, int port,
> +                           struct phy_device *phy)
> +{
> +     if (port < dev->phy_port_cnt) {
> +             /* SUPPORTED_Asym_Pause and SUPPORTED_Pause can be removed to
> +              * disable flow control when rate limiting is used.
> +              */
> +             phy->advertising = phy->supported;
> +     }
> +}
> +

This has nothing to do with MIBs. It does not belong in this patch.

>  static void ksz9477_port_setup(struct ksz_device *dev, int port, bool 
> cpu_port)
>  {
>       u8 data8;
> @@ -1159,6 +1198,8 @@ static int ksz9477_setup(struct dsa_switch *ds)
>       /* start switch */
>       ksz_cfg(dev, REG_SW_OPERATION, SW_START, true);
>  
> +     ksz_init_mib_timer(dev);
> +
>       return 0;
>  }
>  
> @@ -1168,6 +1209,7 @@ static int ksz9477_setup(struct dsa_switch *ds)
>       .set_addr               = ksz9477_set_addr,
>       .phy_read               = ksz9477_phy_read16,
>       .phy_write              = ksz9477_phy_write16,
> +     .adjust_link            = ksz_adjust_link,

Please move the adjust_link changes into a separate patch.

I need to come back at look at the mutex's and the freeze code. It is
not obviously correct, and i don't have the time at the moment.

       Andrew

Reply via email to