Hi, On Tue, Oct 3, 2017 at 8:56 PM, Masahiro Yamada <yamada.masah...@socionext.com> wrote: > The first "_all" occurrence around line 120 is only visible when > KBUILD_SRC is unset. > > If O=... is specified, the working directory is relocated, then the > only second occurrence around line 193 is visible, that is not set > to PHONY. > > Move the first one to an always visible place. This clarifies "_all" > is our default target and it is always set to PHONY. > > Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> > --- > > Makefile | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-)
I'm a professed non-expert on the kernel build so take my review FWIW... I'd definitely agree that it looks like it was a bug (though not a huge one) that it was possible for "_all" not to get marked PHONY. Other than that this change just makes things a little more readable since (if I followed all the Makefile code properly) prior to your change "_all" always ended up being the default rule, just in a very roundabout way. Reviewed-by: Douglas Anderson <diand...@chromium.org>
