> -----Original Message----- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Monday, October 02, 2017 18:37 > To: Razvan Stefanescu <razvan.stefane...@nxp.com> > Cc: gre...@linuxfoundation.org; de...@driverdev.osuosl.org; linux- > ker...@vger.kernel.org; net...@vger.kernel.org; ag...@suse.de; > a...@arndb.de; Alexandru Marginean <alexandru.margin...@nxp.com>; > Bogdan Purcareata <bogdan.purcare...@nxp.com>; Ruxandra Ioana Radulescu > <ruxandra.radule...@nxp.com>; Laurentiu Tudor <laurentiu.tu...@nxp.com>; > stuyo...@gmail.com > Subject: Re: [PATCH v2 3/6] staging: fsl-dpaa2/ethsw: Add ethtool support > > Hi Razvan > > > +static void ethsw_get_drvinfo(struct net_device *netdev, > > + struct ethtool_drvinfo *drvinfo) > > +{ > > + struct ethsw_port_priv *port_priv = netdev_priv(netdev); > > + u16 version_major, version_minor; > > + int err; > > + > > + strlcpy(drvinfo->driver, KBUILD_MODNAME, sizeof(drvinfo->driver)); > > + strlcpy(drvinfo->version, ethsw_drv_version, sizeof(drvinfo->version)); > > Software driver versions are mostly useless. I would suggest you > remove this. > > Andrew Thank you. I'll remove it in v3.
Best regards, Razvan S.
