On Tue, Sep 26, 2017 at 08:18:54PM +0000, mario.limoncie...@dell.com wrote: > > -----Original Message----- > > From: Pali Rohár [mailto:pali.ro...@gmail.com] > > Sent: Tuesday, September 26, 2017 4:06 PM > > To: Limonciello, Mario <mario_limoncie...@dell.com> > > Cc: dvh...@infradead.org; Andy Shevchenko <andy.shevche...@gmail.com>; > > LKML <linux-kernel@vger.kernel.org>; platform-driver-...@vger.kernel.org; > > quasi...@google.com > > Subject: Re: [PATCH v2 09/14] platform/x86: dell-smbios: rename to dell-wmi- > > smbios > > > > On Tuesday 26 September 2017 20:50:07 Mario Limonciello wrote: > > > This follows the style of the rest of the platform x86 WMI drivers. > > > > > > Renaming the driver requires adjusting the other drivers using > > > dell-smbios to pick up the newly named includes. > > > > > > While renaming, I noticed that this driver was missing from > > > MAINTAINERS. Add it to that and myself to the list of people > > > maintaing it. > > > > > > Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> > > > > Now when driver supports both old and new WMI call interface, I think > > that renaming is not needed... > > > > So all other drivers that use WMI have "WMI" in the name, this would be > breaking previously set precedence. Daren, Andy, what would you like > me to do?
I'm leaning toward Pali's point of view here. In fact, I think the driver name should reflect WHAT it does as opposed to HOW it does it. vendor-hotkeys is a much better name than vendor-wmi. We have a lot of drivers that are not nicely granular and use more generic terms like -acpi or -laptop, but those shouldn't be the first choice in my opinion. Now, is SMBIOS any better than WMI? :-) Not really, but it is at least as good as, and less change makes it the winner IMO. -- Darren Hart VMware Open Source Technology Center
