On Fri, Apr 27, 2007 at 07:09:35PM -0700, Andrew Morton wrote: > > +/* > > + * h8300 interrupt controler implementation > > + */ > > +struct irq_chip h8300irq_chip = { > > + .name = "H8300-INTC", > > + .startup = h8300_startup_irq, > > + .shutdown = h8300_shutdown_irq, > > + .enable = h8300_enable_irq, > > + .disable = h8300_disable_irq, > > + .ack = NULL, > > + .end = h8300_end_irq, > > +}; > > I think this could have static scope.
Pluse there's not need to set .ack to NULL explicitly. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/