Re: [PATCH v5 01/10] arm64: dts: allwinner: Restore EMAC changes

[Maxime Ripard]

On Fri, Sep 08, 2017 at 09:11:47AM +0200, Corentin Labbe wrote:
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts 
> b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
> index 1c2387bd5df6..968908761194 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
> @@ -50,6 +50,7 @@
>       compatible = "friendlyarm,nanopi-neo2", "allwinner,sun50i-h5";
>  
>       aliases {
> +             ethernet0 = &emac;
>               serial0 = &uart0;
>       };
>  
> @@ -108,6 +109,22 @@
>       status = "okay";
>  };
>  
> +&emac {
> +     pinctrl-names = "default";
> +     pinctrl-0 = <&emac_rgmii_pins>;
> +     phy-supply = <&reg_gmac_3v3>;
> +     phy-handle = <&ext_rgmii_phy>;
> +     phy-mode = "rgmii";
> +     status = "okay";
> +};
> +
> +&mdio {
> +     ext_rgmii_phy: ethernet-phy@7 {
> +             compatible = "ethernet-phy-ieee802.3-c22";
> +             reg = <7>;
> +     };
> +};
> +

This won't compile, you don't have that node in the H5 DTSI.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

signature.asc
Description: PGP signature