Hi Steve, On Thu, Sep 7, 2017 at 11:10 AM, Steve Muckle <smuc...@google.com> wrote: > On 09/07/2017 09:14 AM, Joel Fernandes wrote: >> >> I'm planning to rebase this series on Linus's master and post it >> again, but just checking any thoughts about it? >> >> Just to add more context, the reason for not updating the frequency: >> >> - When a last dequeue of a sleeping task happens, it is sufficient to >> update utilization without updating the frequency because if other >> CPUs are busy then their updates will consider the utilization of the >> idle CPU in the shared policy unless sufficient time has passed. >> >> - If the last dequeue of a sleeping task happens while all other CPUs >> in the cluster are idle, then the cluster will likely enter >> cluster-idle soon. > > > To clarify - when you say "last dequeue of a sleeping task happens" above, > you're referring to the dequeue of the last task running on the CPU, > correct? I.e. the CPU is about to go idle?
Yes that's right, sorry for my poor choice of words. I am referring to dequeue of a task that is DEQUEUE_SLEEP and is the only task on the RQ. > It's been a while since I've looked at this area so would like to hold off > for a rebased version to review in further detail. But I think the concept > is valid. Sure and thanks for making time for the review! -Joel