On Thu, 2017-09-07 at 12:40 -0400, Steven Rostedt wrote: > On Tue, 5 Sep 2017 16:57:31 -0500 > Tom Zanussi <tom.zanu...@linux.intel.com> wrote: > > > @@ -1786,6 +1786,12 @@ static bool hist_trigger_match(struct > > event_trigger_data *data, > > return false; > > if (key_field->is_signed != key_field_test->is_signed) > > return false; > > + if ((key_field->var.name && !key_field_test->var.name) || > > + (!key_field->var.name && key_field_test->var.name)) > > + return false; > > Short cut: > > if (!!key_field->var.name != !!key_field_test->var.name) > return false; >
Nice! > > + if ((key_field->var.name && key_field_test->var.name) && > > Only need to test if key_field->var.name, as the previous if statement > would exit out if key_field_test->var.name is false. > OK, will change, thanks. Tom
