On Thu, 2017-09-07 at 15:53 +0530, gaurav jindal wrote:
> This patch fixes the below checkpatch errors and warnings in
> drivers/cpuidle/cpuidle.c

If you are going to propose a checkpatch only patch,
please run your proposed patch through checkpatch.

> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
[]
> 
> @@ -399,9 +400,12 @@ int cpuidle_enable_device(struct cpuidle_device *dev)
>       if (ret)
>               return ret;
>  
> -     if (cpuidle_curr_governor->enable &&
> -         (ret = cpuidle_curr_governor->enable(drv, dev)))
> -             goto fail_sysfs;
> +     if (cpuidle_curr_governor->enable) {
> +
> +             ret = cpuidle_curr_governor->enable(drv, dev);
> +             if (ret)
> +                     goto fail_sysfs;
> +     }

checkpatch should complain here about unnecessary
blank line after open brace

Reply via email to