On Wed, Aug 30, 2017 at 01:28:28PM -0700, Andrew Morton wrote:
> On Wed, 30 Aug 2017 13:02:22 +0530 Prakash Gupta <gup...@codeaurora.org> 
> wrote:
> 
> > The stacktraces always begin as follows:
> > 
> >  [<c00117b4>] save_stack_trace_tsk+0x0/0x98
> >  [<c0011870>] save_stack_trace+0x24/0x28
> >  ...
> > 
> > This is because the stack trace code includes the stack frames for itself.
> > This is incorrect behaviour, and also leads to "skip" doing the wrong thing
> > (which is the number of stack frames to avoid recording.)
> > 
> > Perversely, it does the right thing when passed a non-current thread.  Fix
> > this by ensuring that we have a known constant number of frames above the
> > main stack trace function, and always skip these.
> > 
> > This was fixed for arch arm by Commit 3683f44c42e9 ("ARM: stacktrace: avoid
> > listing stacktrace functions in stacktrace")
> 
> I can take this (with acks, please?)

In case you haven't picked it up already:

Acked-by: Catalin Marinas <catalin.mari...@arm.com>

Reply via email to