On Mon, Aug 28, 2017 at 04:13:38PM +0200, Hans de Goede wrote: > Hi, > > On 28-08-17 16:08, Greg Kroah-Hartman wrote: > > On Fri, Aug 25, 2017 at 03:11:25PM +0200, Hans de Goede wrote: > > > Hi, > > > > > > On 25-08-17 15:10, Greg Kroah-Hartman wrote: > > > > On Fri, Aug 25, 2017 at 01:56:23PM +0200, Hans de Goede wrote: > > > > > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > > > > > Cc: Arnd Bergmann <a...@arndb.de> > > > > > Signed-off-by: Hans de Goede <hdego...@redhat.com> > > > > > --- > > > > > MAINTAINERS | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > > index 6a349b5c0c2a..db633caa5a1d 100644 > > > > > --- a/MAINTAINERS > > > > > +++ b/MAINTAINERS > > > > > @@ -3284,6 +3284,7 @@ T: git > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git > > > > > S: Supported > > > > > F: drivers/char/* > > > > > F: drivers/misc/* > > > > > +F: drivers/virt/* > > > > > > > > Really? I'm now in charge of this directory too? That's news to me... > > > > > > This was suggested by Arnd, as he preferred putting the vboxguest driver > > > under drivers/virt rather then drivers/misc. Note that currently there is > > > only one .c file under drivers/virt: fsl_hypervisor.c > > > > Ok, but how about we wait until there is more than one file in here? > > That is fine by me. > > > And what happened to all of the other "virt" drivers, why are they not here? > > Some vmware drivers are currently under drivers/misc, Arnd's proposal was > to move those to drivers/virt. virtio and hyperv have their own subsys > dirs. > > > Perhaps using this directory isn't really a good idea? > > I started out with the same idea which is why v1 of my RFC posting of the > vboxguest driver used drivers/misc, alternatively we could move the single > driver currently under drivers/virt to drivers/misc and stop using > drivers/virt. > > > I don't know... > > Arnd indicated he has a preference for using drivers/virt for vboxguest + > the vmware drivers, I'm fine either way. This really is a bit of a bikeshed- > ish discussion IMHO. So if you and/or Arnd pick one I will happily follow > whatever you choose.
Ah, if we move the vmware ones there, I have no problem with it, I missed that part of the discussion. thanks, greg k-h
