ALIGN+GLOBAL is effectively what ENTRY does, so use ENTRY which is
dedicated for exactly this purpose -- global functions.

Note that stub32_clone is a C-like leaf function -- it has a standard
call frame -- it only switches one argument and continues by jumping
into C. And since each ENTRY should be balanced by some END*, we add a
corresponding ENDPROC to stub32_clone too.

Besides that, x86's custom GLOBAL macro is going to die very soon.

Signed-off-by: Jiri Slaby <jsl...@suse.cz>
Cc: "H. Peter Anvin" <h...@zytor.com>
Cc: Thomas Gleixner <t...@linutronix.de>
Cc: Ingo Molnar <mi...@redhat.com>
Cc: <x...@kernel.org>
---
 arch/x86/entry/entry_64_compat.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/entry/entry_64_compat.S b/arch/x86/entry/entry_64_compat.S
index d8468ba24be0..e26c25ca7756 100644
--- a/arch/x86/entry/entry_64_compat.S
+++ b/arch/x86/entry/entry_64_compat.S
@@ -340,8 +340,7 @@ ENTRY(entry_INT80_compat)
        jmp     restore_regs_and_iret
 END(entry_INT80_compat)
 
-       ALIGN
-GLOBAL(stub32_clone)
+ENTRY(stub32_clone)
        /*
         * The 32-bit clone ABI is: clone(..., int tls_val, int *child_tidptr).
         * The 64-bit clone ABI is: clone(..., int *child_tidptr, int tls_val).
@@ -351,3 +350,4 @@ GLOBAL(stub32_clone)
         */
        xchg    %r8, %rcx
        jmp     sys_clone
+ENDPROC(stub32_clone)
-- 
2.14.1

Reply via email to