On Tue 18 Jul 23:39 PDT 2017, fengl...@codeaurora.org wrote:

> From: Fenglin Wu <fengl...@codeaurora.org>
> 
> Power source selection in DIG_VIN_CTL is indexed from 0, in the range
> check it shouldn't be equal to the total number of power sources.
> 

Acked-by: Bjorn Andersson <bjorn.anders...@linaro.org>

Regards,
Bjorn

> Signed-off-by: Fenglin Wu <fengl...@codeaurora.org>
> ---
>  drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c 
> b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index 664b641..8b77c04 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -375,7 +375,7 @@ static int pmic_gpio_config_set(struct pinctrl_dev 
> *pctldev, unsigned int pin,
>                       pad->is_enabled = false;
>                       break;
>               case PIN_CONFIG_POWER_SOURCE:
> -                     if (arg > pad->num_sources)
> +                     if (arg >= pad->num_sources)
>                               return -EINVAL;
>                       pad->power_source = arg;
>                       break;
> -- 
> Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project.
> 

Reply via email to