> +config DMAR
> + bool "Support for DMA Remapping Devices (EXPERIMENTAL)"
> + depends on PCI_MSI && ACPI && EXPERIMENTAL
> + help
> + Support DMA Remapping Devices. The devices are reported via
> + ACPI tables and includes pci device scope under each DMA
> + remapping device.
The description needs to explain what a dma remapping device is.
And some high level comment here what this file does.
> +
> +LIST_HEAD(dmar_drhd_units);
> +LIST_HEAD(dmar_rmrr_units);
Comment describing what lock protects those lists?
In fact there seems to be no locking. What about hotplug?
>
> +
> + dmar = (struct acpi_table_dmar *)table;
> + if (!dmar) {
> + printk (KERN_WARNING PREFIX "Unable to map DMAR\n");
> + return -ENODEV;
> + }
Shouldn't that be wherever the table is mapped. Or is it not needed?
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
