On Fri, Apr 20, 2007 at 03:00:28PM -0400, Dave Jones wrote:
> On Fri, Apr 20, 2007 at 11:29:52AM -0700, Greg Kroah-Hartman wrote:
> > On Fri, Apr 20, 2007 at 02:20:29PM -0400, Dave Jones wrote:
> > >
> > > btw Greg, wtf does driver_register return a 0 as 'success' if it
> > > completes the function, and 0 as 'failure' if !bus ?
> > > That seems doomed to failure.
> >
> > I don't know why the code does that, we should always have a bus
> > assigned to a driver. I'll change that and watch to see what breaks :)
>
> Maybe this?
>
> We should always have a bus in bus_add_driver()
> Instead of returning success when we don't, BUG().
Nah, I don't like adding BUG() calls to the kernel if it can be helped,
how about the version I copied you on a few hours ago, which is also
below?
thanks,
greg k-h
------
From: Greg Kroah-Hartman <[EMAIL PROTECTED]>
Subject: driver core: bus_add_driver should return an error if no bus
As pointed out by Dave Jones.
Cc: Dave Jones <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
---
drivers/base/bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/base/bus.c
+++ b/drivers/base/bus.c
@@ -601,7 +601,7 @@ int bus_add_driver(struct device_driver
int error = 0;
if (!bus)
- return 0;
+ return -EINVAL;
pr_debug("bus %s: add driver %s\n", bus->name, drv->name);
error = kobject_set_name(&drv->kobj, "%s", drv->name);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
