On 7/30/17 12:07 AM, Mike Rapoport wrote:
On Thu, Jul 27, 2017 at 10:18:40PM -0400, Prakash Sangappa wrote:
This patch adds tests for UFFD_FEATURE_SIGBUS feature. The
tests will verify signal delivery instead of userfault events.
Also, test use of UFFDIO_COPY to allocate memory and retry
accessing monitored area after signal delivery.
This patch also fixes a bug in uffd_poll_thread() where 'uffd'
is leaked.
Signed-off-by: Prakash Sangappa <prakash.sanga...@oracle.com>
---
Change log
v2:
- Added comments to explain the tests.
- Fixed test to fail immediately if signal repeats.
- Addressed other review comments.
v1: https://lkml.org/lkml/2017/7/26/101
---
Overall looks good to me, just small nitpick below.
[...]
for (nr = 0; nr < split_nr_pages; nr++) {
+ if (signal_test) {
+ if (sigsetjmp(*sigbuf, 1) != 0) {
+ if (nr == lastnr) {
+ sig_repeats++;
You can simply 'return 1' here, then sig_repeats variable can be dropped
and the return statement for signal_test can be simplified.
Ok, sent v3 patch with this change.
Thanks,
-Prakash.
