Commit-ID:  332337dafc98d88561bf3730f80c59cc93f089e1
Gitweb:     http://git.kernel.org/tip/332337dafc98d88561bf3730f80c59cc93f089e1
Author:     Arnaldo Carvalho de Melo <a...@redhat.com>
AuthorDate: Wed, 19 Jul 2017 15:08:14 -0300
Committer:  Arnaldo Carvalho de Melo <a...@redhat.com>
CommitDate: Thu, 20 Jul 2017 09:55:53 -0300

perf trace: Allow specifying number of syscall args for tracepointless syscalls

When we don't have syscalls:sys_{enter,exit}_NAME, we had to resort to
dumping all the 6 syscall arguments, fix it by providing that info for
such syscalls, like 'clone'.

Cc: Adrian Hunter <adrian.hun...@intel.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Jiri Olsa <jo...@kernel.org>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Wang Nan <wangn...@huawei.com>
Link: http://lkml.kernel.org/n/tip-dfq1jtrxj8dqvqoeqqpr3...@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <a...@redhat.com>
---
 tools/perf/builtin-trace.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index f8b7bfd..e1988d0 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -611,6 +611,7 @@ static struct syscall_fmt {
        const char *name;
        const char *alias;
        struct syscall_arg_fmt arg[6];
+       u8         nr_args;
        bool       errpid;
        bool       timeout;
        bool       hexret;
@@ -1169,6 +1170,9 @@ static int syscall__alloc_arg_fmts(struct syscall *sc, 
int nr_args)
 {
        int idx;
 
+       if (nr_args == 6 && sc->fmt && sc->fmt->nr_args != 0)
+               nr_args = sc->fmt->nr_args;
+
        sc->arg_fmt = calloc(nr_args, sizeof(*sc->arg_fmt));
        if (sc->arg_fmt == NULL)
                return -1;
@@ -1413,7 +1417,7 @@ static size_t syscall__scnprintf_args(struct syscall *sc, 
char *bf, size_t size,
                 * may end up not having any args, like with gettid(), so only
                 * print the raw args when we didn't manage to read it.
                 */
-               while (arg.idx < 6) {
+               while (arg.idx < sc->nr_args) {
                        if (arg.mask & bit)
                                goto next_arg;
                        val = syscall_arg__val(&arg, arg.idx);

Reply via email to