4.4-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Chao Yu <yuch...@huawei.com>

commit 1ea1516fbbab2b30bf98c534ecaacba579a35208 upstream.

kstrtoull returns 0 on success, however, in reserved_clusters_store we
will return -EINVAL if kstrtoull returns 0, it makes us fail to update
reserved_clusters value through sysfs.

Fixes: 76d33bca5581b1dd5c3157fa168db849a784ada4
Signed-off-by: Chao Yu <yuch...@huawei.com>
Signed-off-by: Miao Xie <miao...@huawei.com>
Signed-off-by: Theodore Ts'o <ty...@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

---
 fs/ext4/sysfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/ext4/sysfs.c
+++ b/fs/ext4/sysfs.c
@@ -100,7 +100,7 @@ static ssize_t reserved_clusters_store(s
        int ret;
 
        ret = kstrtoull(skip_spaces(buf), 0, &val);
-       if (!ret || val >= clusters)
+       if (ret || val >= clusters)
                return -EINVAL;
 
        atomic64_set(&sbi->s_resv_clusters, val);


Reply via email to