This patch sets memory to zero directly to avoid unnecessary shift and
bitwise operations on bool type, which can fix a sparse warning and also
improve performance.

Signed-off-by: Rui Teng <rui.t...@linux.vnet.ibm.com>
---
 drivers/staging/wilc1000/host_interface.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c 
b/drivers/staging/wilc1000/host_interface.c
index 2568dfc15181..036c5c19a016 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -2416,10 +2416,9 @@ static void Handle_SetMulticastFilter(struct wilc_vif 
*vif,
                goto ERRORHANDLER;
 
        pu8CurrByte = wid.val;
-       *pu8CurrByte++ = (strHostIfSetMulti->enabled & 0xFF);
-       *pu8CurrByte++ = ((strHostIfSetMulti->enabled >> 8) & 0xFF);
-       *pu8CurrByte++ = ((strHostIfSetMulti->enabled >> 16) & 0xFF);
-       *pu8CurrByte++ = ((strHostIfSetMulti->enabled >> 24) & 0xFF);
+       memset(pu8CurrByte, 0, 4);
+       *pu8CurrByte = (strHostIfSetMulti->enabled & 0xFF);
+       pu8CurrByte += 4;
 
        *pu8CurrByte++ = (strHostIfSetMulti->cnt & 0xFF);
        *pu8CurrByte++ = ((strHostIfSetMulti->cnt >> 8) & 0xFF);
-- 
2.11.0

Reply via email to