On 2017/7/1 15:48, Jaegeuk Kim wrote: > On 06/29, Chao Yu wrote: >> From: Chao Yu <yuch...@huawei.com> >> >> Don't clear old mount option before parse new option during ->remount_fs >> like other generic filesystems. > > So, what happened on your original patch? > > commit 26666c8a4366debae30ae37d0688b2bec92d196a > f2fs: fix to clean previous mount option when remount_fs
I think that patch is wrong, since the manual doesn't describe kernel logic, so I'd like revert that patch, then f2fs ->remount_fs logic is more like generic filesystem. Thanks, > > I think we need to rever the original patch tho.> > Thanks, > >> >> Signed-off-by: Chao Yu <yuch...@huawei.com> >> --- >> fs/f2fs/super.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c >> index f27c141cd8aa..af472f7968d0 100644 >> --- a/fs/f2fs/super.c >> +++ b/fs/f2fs/super.c >> @@ -846,7 +846,6 @@ static int f2fs_remount(struct super_block *sb, int >> *flags, char *data) >> clear_sbi_flag(sbi, SBI_NEED_SB_WRITE); >> } >> >> - sbi->mount_opt.opt = 0; >> default_options(sbi); >> >> /* parse mount options */ >> -- >> 2.13.0.90.g1eb437020
