Re: [PATCH] EDAC: Get rid of mci->mod_ver

[Thor Thayer]

On 06/29/2017 05:03 AM, Borislav Petkov wrote:

Hi,

any objections?

---
It is a write-only variable so get rid of it.

Signed-off-by: Borislav Petkov <b...@suse.de>
Cc: Thor Thayer <thor.tha...@linux.intel.com>
Cc: Mark Gross <mark.gr...@intel.com>
Cc: Robert Richter <r...@kernel.org>
Cc: Tim Small <t...@buttersideup.com>
Cc: Ranganathan Desikan <r...@jetztechnologies.com>
Cc: "Arvind R." <arvin...@gmail.com>
Cc: Jason Baron <jba...@akamai.com>
Cc: Tony Luck <tony.l...@intel.com>
Cc: Michal Simek <michal.si...@xilinx.com>
Cc: "Sören Brinkmann" <soren.brinkm...@xilinx.com>
Cc: Ralf Baechle <r...@linux-mips.org>
Cc: David Daney <david.da...@cavium.com>
Cc: Loc Ho <l...@apm.com>
Cc: linux-e...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-m...@linux-mips.org
---
  drivers/edac/altera_edac.c      | 2 --

<snip>

diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
index db75d4b614f7..fa2e5db56d24 100644
--- a/drivers/edac/altera_edac.c
+++ b/drivers/edac/altera_edac.c
@@ -38,7 +38,6 @@
  #include "edac_module.h"

#define EDAC_MOD_STR "altera_edac"

-#define EDAC_VERSION           "1"
  #define EDAC_DEVICE           "Altera"

<snip>

Looks fine for Altera EDAC.

Acked-by: Thor Thayer <thor.tha...@linux.intel.com>