> -----Original Message----- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Monday, June 19, 2017 12:49 PM > To: Ghannam, Yazen <yazen.ghan...@amd.com> > Cc: linux-e...@vger.kernel.org; Tony Luck <tony.l...@intel.com>; > x...@kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] x86/mce: Always save severity in machine_check_poll > > > Just forget the work scheduling - it is only a marginal implementation thing - > you only want to say that we want to log the severity since we already have > it. > And the most important aspect in your v2 commit message is explaining > *why* we want the severity. And yes, it is possible to simply say, this is a > cleanup and we can just as well always save it because it is a valid reason. > And > it makes sense too. > > All I'm trying to remind you of, is, you should explain in your commit message > what the issue is and *why* you're doing the change. When the first sentence > of your commit message is "Remove code that was used to decide whether to > schedule work." I'm starting to scratch my head, wondering, what the actual > problem is and what you're trying to fix. > > Ok? >
Yep, got it. Thanks, Yazen
