Re: [PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for bus_type

[Stephen Rothwell]

Hi Greg,

On Sat, 10 Jun 2017 09:56:49 +1000 Stephen Rothwell <s...@canb.auug.org.au> 
wrote:
>
> > +static struct attribute *serdev_device_attrs[] = {  
>                             ^^^^^^^^^^^^^^^^^^^
> Should have been "serdev_device_groups"

Sorry, my mistake.

> > +   &dev_attr_modalias.attr,
> > +   NULL,
> >  };
> > +ATTRIBUTE_GROUPS(serdev_device);

I really hate macros that create symbols by concatenating parts. :-(

-- 
Cheers,
Stephen Rothwell