On Fri, Jun 9, 2017 at 1:06 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Fri, Jun 9, 2017 at 5:46 PM, Daniel Lezcano > <daniel.lezc...@linaro.org> wrote: >> On Tue, Jun 06, 2017 at 04:17:40PM +0200, Ulf Hansson wrote: >>> On 5 June 2017 at 20:13, Daniel Lezcano <daniel.lezc...@linaro.org> wrote: >>> > With the addition of the hi655x common clock, the config option is missing >>> > for the ARM64's hi6220 platform. That leads to a non functionnal WiFi >>> > because >>> > the hi655x clock driver misses when initializing the power sequence via >>> > DT. >>> > >>> > Cc: John Stultz <john.stu...@linaro.org> >>> > Cc: Ulf Hansson <ulf.hans...@linaro.org> >>> > Cc: Wei Xu <xuw...@hisilicon.com> >>> > Signed-off-by: Daniel Lezcano <daniel.lezc...@linaro.org> >>> >>> Acked-by: Ulf Hansson <ulf.hans...@linaro.org> >>> >>> Would be nice to get this trivial fix in for 4.12 rcs to make the WiFi >>> work for Hikey. >>> >> >> I'm wondering if I submitted this patch for the right path. >> >> Shall it go through arm-soc ? > > Yes, but I'm not sure this is the right patch either. We tend to not > use 'select' for user-visible drivers, and most hisilicon platforms > won't need this driver. > > I think it would be more consistent to add this to the defconfig > and regard it as a user error when the driver is disabled on a > machine that needs it.
Maybe the select is not exactly in the right place, but I don't really feel like a pmic on an SoC is a "user-visible driver". I deal with the board often and when the new dependency was made on the clk, I would have never have found it on my own w/o Ulf and Daniel pointing out what I needed to enable. thanks -john
