Hello Geert, On 04/25/2017 08:40 PM, Geert Uytterhoeven wrote: > If CONFIG_OF=n, code using > > info = of_match_node(matchs, np)->data; > > fails to compile: > > warning: dereferencing ‘void *’ pointer > error: request for member ‘data’ in something not a structure or union
IMHO firstly all the cases like one above must be fixed in place, in parallel do an overall conversion of subcases: - of_id = of_match_node(some_dt_ids, dev->of_node); + of_id = of_match_device(some_dt_ids, dev); > Follow the example set by of_device_get_match_data(), and introduce a > new helper of_node_get_match_data(). This will allow to increase > compile-testing coverage later. Unfortunately the proposed of_node_get_match_data() is not so similar to the of_device_get_match_data(), the latter one has only one input argument in opposite to of_match_device(), which is truly convenient. > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> The change itself is good. Reviewed-by: Vladimir Zapolskiy <vladimir_zapols...@mentor.com> -- With best wishes, Vladimir
