On Mon, 9 Apr 2007, Andrew Morton wrote: > On Mon, 9 Apr 2007 11:25:20 -0700 (PDT) > Christoph Lameter <[EMAIL PROTECTED]> wrote: > > > -static inline pgd_t *pgd_alloc(struct mm_struct *mm) > > +static inline void pgd_ctor(void *x) > > +static inline void pgd_dtor(void *x) > > Seems dumb to inline these - they're only ever called indirectly, aren't > they?
Yes.. In most cases they are not called at all because NULL is passed. Then the function call can be removed by the compiler from the in line functions. > This means (I think) that the compiler will need to generate an out-of-line > copy of these within each compilation unit which passes the address of these > functions into some other function. The function is constant. Constant propagation will lead to the function being included in the inline function. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
