Hi Florian, Florian Fainelli <f.faine...@gmail.com> writes:
> On 06/06/2017 01:56 PM, Vivien Didelot wrote: >> Now that the VLAN object is propagated to every switch chip of the >> switch fabric, we can easily ensure that they all support the required >> VLAN operations before modifying an entry on a single switch. >> >> To achieve that, remove the condition skipping other target switches, >> and add a bitmap of VLAN members, eventually containing the target port, >> if we are programming the switch target. > > You could add in the commit message that with this commit, there is not > actually a functional change yet because we have one (and only one) bit > set in the members bitmap. Hum there is a small functional change though: if one interconnected switch of the fabric does not support the VLAN operations, -EOPNOTSUPP is returned (even though the target switch is VLAN capable.) Thanks, Vivien