On Tuesday 06 June 2017 13:46:16 mario.limoncie...@dell.com wrote:
> Pali,
>
> Amazing job with what you've done so far. A few comments I wanted to share
> from my taking look at your bmf2mof and comparing to "source" MOF.
> 1) At least in source the case used for String and Boolean is lower case.
> I'm unsure if that actually matters for any MOF parsing tools, but I wanted
> to FYI in case it does.
In MS documentation is String, Boolean and Datetime with first char
uppercase. But looks like mofcomp accept both upper case and lower case
variants.
> 2) On my system when you expand the arguments for "void DoBFn" the source
> doesn't describe individual arguments like you do.
> Again this might not matter to MOF parsing tools but wanted to let you know
> in case it does.
I know, this part is missing. Order of arguments are only in ID
qualifier and not sorted + in/out de-duplicated.
> source:
> void DoBFn([in, out, Description("Fn buf")] BDat Data);
> bmf2mof:
> void doBFn([in, Description("Fn buf"), ID(0)] BDat Data, [out,
> Description("Fn buf"), ID(0)] BDat Data);
--
Pali Rohár
pali.ro...@gmail.com
