On Fri, May 26, 2017 at 8:17 PM, Roshni Shah <roshni.s...@timesys.com> wrote:
> @@ -81,14 +82,26 @@ static const struct ad_dpot_bus_ops bops = {

> +static const struct of_device_id ad_dpot_spi_of_match[] = {
> +       {
> +               .compatible     = "ad,ad5160",
> +               .name           = "ad5160",
> +               .data           = (void *)AD5160_ID,
> +       },
> +       {
> +               .compatible     = "ad,ad5161",
> +               .name           = "ad5161",
> +               .data           = (void *)AD5161_ID,
> +       },

You should only match on 'compatible', not on 'name'. By convention,
the name just describes what the device does.

      Arnd

Reply via email to