Hi Michael On Fri, May 19, 2017 at 09:44:40AM +0200, Micha?? K??pie?? wrote: > fujitsu-laptop registers two ACPI drivers that access each other's > module-wide structures. To improve data encapsulation and lay the > groundwork for separating the two aforementioned ACPI drivers into > separate modules, move away from module-wide global data structures by > using device-specific data instead. > :
I have had a quick look through this series. To my eye it addresses the outcome of our discussion over the last couple of weeks, and looks good. I had one query regarding patch 5/8, but that might just be a case of me not knowing about a subtlety of WARN_ONCE(). In any case this isn't a major issue and would be easily resolved if needed. Once I get feedback on patch 5/8 (and after seeing any additional comments from Darren et al) I can send through a reviewed-by. Regards jonathan
