On 04/21/2017 02:17 AM, Zi Yan wrote: > From: Naoya Horiguchi <[email protected]> > > pmd_present() checks _PAGE_PSE along with _PAGE_PRESENT to avoid > false negative return when it races with thp spilt > (during which _PAGE_PRESENT is temporary cleared.) I don't think that > dropping _PAGE_PSE check in pmd_present() works well because it can > hurt optimization of tlb handling in thp split. > In the current kernel, bits 1-4 are not used in non-present format > since commit 00839ee3b299 ("x86/mm: Move swap offset/type up in PTE to > work around erratum"). So let's move _PAGE_SWP_SOFT_DIRTY to bit 1. > Bit 7 is used as reserved (always clear), so please don't use it for > other purpose. > > Signed-off-by: Naoya Horiguchi <[email protected]> > Signed-off-by: Zi Yan <[email protected]>
+Dave Hansen +Andi Kleen Dave/Andi/Kiril, Does this change looks okay ? Its been on the list for some time now. Could you please have a look into this and lets us know your inputs/suggestions/comments ? Thank you. - Anshuman
