On Tue, May 09, 2017 at 03:45:03PM +0200, Jiri Olsa wrote: > On Tue, May 09, 2017 at 05:29:24AM -0700, Andi Kleen wrote: > > > so the -F option for 'type:' does not have default set, > > > and it looks like the +- don't make sense there: > > > > hw:+comm is just equivalent to hw:comm > > > > Seems fine to me? > > > > hw:-comm won't do anything, but I guess that's expected. > > > > Don't see any need to change this? > > why did you add it in the first place then?
You mean the Don't override defaults check in the hw types specified case? I guess it could be removed yes. -Andi
