v2:
---
Thanks for the comments and ideas from Arnaldo and Milian.
1. Change "Percnt" to "Percent"
2. Add explanations for "Percent", "IPC" and "Cycle".
When user hit hotkey 'h', the help window is popup. Explanations
are added at the bottom of window.
│Report explanation: │
│ Percent: sample percentage for a block │
│ IPC: instructions per cycle for a block │
│ cycle: average number of cycles for a block │
I don't use a new window to display the report explanation,
instead, I just display the info in current help window so that
user doesn't need to press one more hotkey to get the explanation.
Changed patch:
--------------
perf report: Display titles in left frame of annotate browser
Unchanged patch:
----------------
perf report: Remove the unnecessary checking in annotate_browser_write
Initial post
------------
The patch series adds the titles "Percnt", "IPC" and "Cycle" in
annotate browser. It helps user to understand easily for what the
columns in left frame represents for.
For example:
Percnt IPC Cycle │
│25 __attribute__((noinline))
│26 int compute_flag()
│27 {
22.80 1.20 │ sub $0x8,%rsp
│25 int i;
│
│27 i = rand() % 2;
22.78 1.20 1 │ → callq rand@plt
The patch "perf report: Remove the unnecessary checking in
annotate_browser_write" removes the invalid condition checking in
current code.
Jin Yao (2):
perf report: Remove the unnecessary checking in annotate_browser_write
perf report: Display titles in left frame of annotate browser
tools/perf/ui/browsers/annotate.c | 59 +++++++++++++++++++++++++++------------
1 file changed, 41 insertions(+), 18 deletions(-)
--
2.7.4
