On Mon, May 01, 2017 at 02:24:27PM +0300, Andy Shevchenko wrote:
[...]
> One nit below.
> FWIW:
> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com>
>
> > +static irqreturn_t adxl345_trigger_handler(int irq, void *p)
> > +{
> > + struct iio_poll_func *pf = p;
> > + struct iio_dev *indio_dev = pf->indio_dev;
> > + struct adxl345_data *data = iio_priv(indio_dev);
> > + int ret;
> > +
> > + mutex_lock(&data->lock);
> > + /* Make sure data is ready when using external trigger */
> > + if (!data->data_ready_trig_on) {
> > + ret = adxl345_data_ready(data);
> > + if (ret < 0)
> > + goto error;
> > + }
> > +
> > + ret = regmap_bulk_read(data->regmap, ADXL345_REG_DATAX0,
> > data->buffer,
> > + sizeof(__le16) * 3);
> > + if (ret < 0)
> > + goto error;
> > +
> > + iio_push_to_buffers_with_timestamp(indio_dev, data->buffer,
> > + pf->timestamp);
>
> > +error:
>
> I would call it 'err_unlock_notify'.
>
OK.
Thanks for the review,
Eva
> > + mutex_unlock(&data->lock);
> > + iio_trigger_notify_done(indio_dev->trig);
> > +
> > + return IRQ_HANDLED;
> > +}
>
> --
> With Best Regards,
> Andy Shevchenko
