Hello Andy, Thus wrote Andy Shevchenko (andy.shevche...@gmail.com):
> On Tue, Apr 18, 2017 at 12:11 PM, Martin Kaiser <mar...@kaiser.cx> wrote: > > checkpatch is asking for a 4 digit octal number. And at least for me, > > 0444 makes it clearer what the permissions actually are. Yes, somewhere > > in the code, I can dig up that 0 is changed to 0444... > Aren't 0 and 0444 different by meaning? my undestanding is that proc_create() calls proc_create_data(), where if ((mode & S_IALLUGO) == 0) mode |= S_IRUGO; sets mode to 0444 when it was 0. Best regards, Martin (added the lkml back to Cc, I removed it by accident in an earlier mail)