On 04/24/2017 06:05 AM, Andi Kleen wrote: > On Sun, Apr 23, 2017 at 09:26:32PM -0700, Tony Jones wrote: >> Guard _GNU_SOURCE (as done in pt-decoder/intel-pt-decoder.c) to prevent >> possible redefinition error. > > Who defines it? > > If it's always defined somewhere else it can be just removed. > > -Andi
sometimes it's defaulted on (I believe) by the toolchain. it fails on our SLE12-SP3 toolchain. I assumed the existing guard in pt-decoder/intel-pt-decoder.c (only other use) was for a reason. tony