On Fri, Apr 7, 2017 at 5:10 PM, Alexandre TORGUE <alexandre.tor...@st.com> wrote:
> Add .get_direction() gpiochip callback in STM32 pinctrl driver. > > Signed-off-by: Alexandre TORGUE <alexandre.tor...@st.com> (...) > +#include <linux/gpio.h> No this is wrong, drivers should never include this file. It is a deprecated consumer header. > + if ((alt == 0) && (mode == 0)) > + ret = GPIOF_DIR_IN; > + else if ((alt == 0) && (mode == 1)) > + ret = GPIOF_DIR_OUT; Just return 0 or 1, that is the driver-internal API. Yours, Linus Walleij
