[PATCH 8/9] platform/x86: hp-wmi: Do not shadow errors in sysfs show functions

[Darren Hart]

From: "Darren Hart (VMware)" <dvh...@infradead.org>

The new hp_wmi_read_int function returns a negative value in case of
error, pass this on directly rather than always replacing it with
-EINVAL.

Signed-off-by: Darren Hart (VMware) <dvh...@infradead.org>
---
 drivers/platform/x86/hp-wmi.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
index ccacd1a..90b8652 100644
--- a/drivers/platform/x86/hp-wmi.c
+++ b/drivers/platform/x86/hp-wmi.c
@@ -402,7 +402,7 @@ static ssize_t display_show(struct device *dev, struct 
device_attribute *attr,
 {
        int value = hp_wmi_read_int(HPWMI_DISPLAY_QUERY);
        if (value < 0)
-               return -EINVAL;
+               return value;
        return sprintf(buf, "%d\n", value);
 }
 
@@ -411,7 +411,7 @@ static ssize_t hddtemp_show(struct device *dev, struct 
device_attribute *attr,
 {
        int value = hp_wmi_read_int(HPWMI_HDDTEMP_QUERY);
        if (value < 0)
-               return -EINVAL;
+               return value;
        return sprintf(buf, "%d\n", value);
 }
 
@@ -420,7 +420,7 @@ static ssize_t als_show(struct device *dev, struct 
device_attribute *attr,
 {
        int value = hp_wmi_read_int(HPWMI_ALS_QUERY);
        if (value < 0)
-               return -EINVAL;
+               return value;
        return sprintf(buf, "%d\n", value);
 }
 
@@ -429,7 +429,7 @@ static ssize_t dock_show(struct device *dev, struct 
device_attribute *attr,
 {
        int value = hp_wmi_hw_state(HPWMI_DOCK_MASK);
        if (value < 0)
-               return -EINVAL;
+               return value;
        return sprintf(buf, "%d\n", value);
 }
 
@@ -438,7 +438,7 @@ static ssize_t tablet_show(struct device *dev, struct 
device_attribute *attr,
 {
        int value = hp_wmi_hw_state(HPWMI_TABLET_MASK);
        if (value < 0)
-               return -EINVAL;
+               return value;
        return sprintf(buf, "%d\n", value);
 }
 
@@ -448,7 +448,7 @@ static ssize_t postcode_show(struct device *dev, struct 
device_attribute *attr,
        /* Get the POST error code of previous boot failure. */
        int value = hp_wmi_read_int(HPWMI_POSTCODEERROR_QUERY);
        if (value < 0)
-               return -EINVAL;
+               return value;
        return sprintf(buf, "0x%x\n", value);
 }
 
-- 
2.9.3